-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Releases/v0.12.latest #83
Conversation
* feat: add non-standard columns to card model. * implement feedback from issue * Apply suggestions from code review Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com> --------- Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just had one clarifying question in the changelog!
stripe_source: | ||
card_pass_through_columns: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie Should we remove these variables? I assume it was only for testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Figured there's no harm in including them in integration tests moving forward 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie A few source notes before approval.
- name: "description" | ||
``` | ||
|
||
## Under the Hood |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie I think something is up with the triple quoting here that is causing the Under the Hood section to be quoted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie lgtm
PR Overview
This PR will address the following Issue/Feature:
#80 by way of including #81
This PR will result in the following new package version:
v0.12.1
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Feature Updates
stg_stripe__card
model. This can, for example, be used to pull in non-standard columns from Stripe such asdescription
,iin
andissuer
. See the README for more details (PR #81).Under the Hood
get_card_columns()
macro and aliased themetadata
field, which is parsed but not wholly included instg_stripe__card
by default.card_pass_through_columns
variable to include these fields instg_stripe__card
.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Ran successfully with the following set of passthrough columns:
If you had to summarize this PR in an emoji, which would it be?
🍏