Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases/v0.12.latest #83

Merged
merged 10 commits into from
Oct 2, 2024
Merged

Releases/v0.12.latest #83

merged 10 commits into from
Oct 2, 2024

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Sep 27, 2024

PR Overview

This PR will address the following Issue/Feature:
#80 by way of including #81

This PR will result in the following new package version:

v0.12.1

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Feature Updates

  • Declaration of passthrough variables for the stg_stripe__card model. This can, for example, be used to pull in non-standard columns from Stripe such as description, iin and issuer. See the README for more details (PR #81).
# dbt_project.yml

vars:
  stripe_source:
    card_pass_through_columns:
      - name: "description"

Under the Hood

  • Removed un-used columns from the get_card_columns() macro and aliased the metadata field, which is parsed but not wholly included in stg_stripe__card by default.
    • This ensures users can utilize the new card_pass_through_columns variable to include these fields in stg_stripe__card.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Ran successfully with the following set of passthrough columns:

  stripe_source:
      card_pass_through_columns:
        - name: "description"
        - name: iin
          transform_sql: cast(iin as string)
        - name: exp_year
          alias: exp_year_alias
          transform_sql: exp_year_alias * 2.0
        - name: metadata
        - name: fingerprint

      stripe__card_metadata:
        - name: external_id

If you had to summarize this PR in an emoji, which would it be?

🍏

bramrodenburg and others added 2 commits September 27, 2024 15:36
* feat: add non-standard columns to card model.

* implement feedback from issue

* Apply suggestions from code review

Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>

---------

Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
@fivetran-jamie fivetran-jamie self-assigned this Sep 27, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just had one clarifying question in the changelog!

stripe_source:
card_pass_through_columns:
Copy link

@fivetran-avinash fivetran-avinash Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie Should we remove these variables? I assume it was only for testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured there's no harm in including them in integration tests moving forward 🤷

Copy link

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie A few source notes before approval.

- name: "description"
```

## Under the Hood

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie I think something is up with the triple quoting here that is causing the Under the Hood section to be quoted.

CHANGELOG.md Show resolved Hide resolved
Copy link

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie fivetran-jamie merged commit 4657edc into main Oct 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants